From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | pgsql(at)mohawksoft(dot)com |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] Configuration patch |
Date: | 2004-06-13 23:55:39 |
Message-ID: | 200406132355.i5DNtdC27141@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
pgsql(at)mohawksoft(dot)com wrote:
> >
> > Where are we on this?
>
> That's a good question.
>
> Tom doesn't like the syntax of "include" and there are a couple bugs he is
> concered it.
>
> I'm pretty agnostic about the syntax, but I wouldn't get overly worried
> about the metaphor presented either.
>
> "include='...'" doesn't bother me at all, but some people have a problem
> with it.
>
> Then there is the design of using a callable function for a configuration
> parameter, personally, I think this feature is useful for the future, Tom
> seems to have a problem it it.
>
> After that, the discussion sort of ends.
>
>
> I'm willing to adress the bugs.
> I don't think the syntax is a huge deal, IMHO at most it is a
> documentation problem.
Well, it seems pretty clear were we need to go on this. First, we could
just add the documentation to the non-include part of the patch based on
the version I posted and apply that to be sure it gets into 7.5.
Then, for "include", it needs to be an operation and not a variable,
probably something in guc-file.l.
It should not use an equals and not be something you can say SHOW with.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-06-13 23:57:18 | Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC |
Previous Message | Tom Lane | 2004-06-13 23:47:22 | Re: File leak? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-06-13 23:57:18 | Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC |
Previous Message | pgsql | 2004-06-13 23:17:49 | Re: [PATCHES] Compiling libpq with VisualC |