Re: pg_ctl using START with paths needing quotes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_ctl using START with paths needing quotes
Date: 2004-06-11 18:04:23
Message-ID: 200406111804.i5BI4Nb13303@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Bruce Momjian wrote:
> >> This applied patch changes the way pg_ctl starts on Win32.
> >>
> >> Using START, it is not possible to quote the executable name, who's
> >> directory might have spaces:
> >
> > This is a really ugly hack (I take the blame since I gave Bruce the
> > idea). There are a few things to note:
>
> > . the .bat file should probably be created in the data dir - that's
> > about the only place that we should be guaranteed we can write.
>
> In that case, haven't we simply moved the spaces problem from the
> executable directory to the data directory?

Yep. That code is all gone now that we have the right fix, use:

START "" "executable"

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Andreas Pflug 2004-06-11 18:14:07 Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC
Previous Message Bruce Momjian 2004-06-11 18:03:28 Re: [PATCHES] Compiling libpq with VisualC

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-06-11 18:07:02 Re: [PATCHES] serverlog function (log_destination file)
Previous Message Bruce Momjian 2004-06-11 18:03:28 Re: [PATCHES] Compiling libpq with VisualC