Re: pg_dump --comment?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump --comment?
Date: 2004-05-31 13:37:36
Message-ID: 200405311337.i4VDbam12872@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Jan Wieck wrote:
> This can be accomplished with 10-20 lines of shell scripting. I don't
> think it's worth the trouble bloating pg_dump with it at all.

Considering how much bloat -v adds, adding a datestamp to it is trivial.
-v outputs things like:

--
-- TOC entry 1449 (class 0 OID 0)
-- Dependencies: 4
-- Name: public; Type: ACL; Schema: -; Owner: postgres
--

so adding a timestamp at the top is probably a good extension.

Actually, the pg_dump -v docs are incorrect because they only mention
additional stderr output, not the additional comments. I updated the
text to:

Specifies verbose mode. This will cause
<application>pg_dump</application> to output detailed object
comments in the dump file, and progress messages to standard error.

This -v functionality controlling comments is new in 7.5.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pierre Emmanuel Gros 2004-05-31 13:38:15 constraint upon view
Previous Message Teodor Sigaev 2004-05-31 13:32:56 Re: yet another contrib module

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-31 17:14:19 New pg_ctl has retrogressed in error messages
Previous Message Jan Wieck 2004-05-31 13:01:39 Re: pg_dump --comment?