Re: [HACKERS] pg_autovacuum fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_autovacuum fixes
Date: 2004-05-26 18:48:37
Message-ID: 200405261848.i4QImbx01974@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Patch applied. Thanks.

Backpatched to 7.4.X.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:
> This weekend I am trying to fix up all known the pg_autovacuum issues
> that should be resolved for 7.4.3. I am aware of only two issues: temp
> table issues, and unchecked send_query() calls, if I am forgetting
> something, please let me know.
>
> 1) temp table issue:
> I was not able to reproduce the crash associated with temp tables. I
> spent a while creating tables doing updates and dropping them trying
> without success to get pg_autovacuum to crash. Since I couldn't trigger
> the problem, I will need someone else to test to see if I have fixed the
> problem. Anyway, I have modified the query to exclude temp tables from
> the list of tables to work with. So we should no longer be dealing with
> temp tables at all which should side step any temp table related problem
> we might have been having.
>
> 2) Unchecked send_query() function calls:
> As best as I can tell, this is mostly a non-issue, but I went ahead
> added a check to any section that did anything with the result of
> send_query, so if this was an issue, it should be fixed now. BTW, this
> might have been the cause of the temp table related crash, but that is
> just a guess.
>
>
> Matthew O'Connor
>
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message pgsql 2004-05-26 20:25:24 tablespaces and DB administration
Previous Message pgsql 2004-05-26 17:18:24 Re: Ingres to be released as open source

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-26 18:50:28 Re: Cancel/Kill backend functions
Previous Message Bruce Momjian 2004-05-26 18:35:09 Re: More network functions...