Re: Revert addition of -lpgport, which breaks the build

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: Revert addition of -lpgport, which breaks the build
Date: 2004-05-21 18:33:45
Message-ID: 200405211833.i4LIXjV15132@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I modified to code so only Win32 will do it.
>
> I think Neil's point is that it fails on OSX as well. Really we have to
> do this the way libpq does, namely pull out the specific files it needs
> and recompile those with the correct shared-library-compatible CFLAGS.

Oh, that one? Yea, I see your point. I thought you meant this from
libpq:

ifeq ($(PORTNAME), win32)
OBJS+=win32.o
endif

Now I realize we are making a library and has to use the same flags.

I will make the separate build change when I return on Sunday.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2004-05-21 20:56:51 pgsql-server: Put path configuration information into a .h file instead
Previous Message Tom Lane 2004-05-21 16:22:39 pgsql-server: Probably need sys/time.h here too to be safe.