Re: pg_ctl patch to integrate apache's rotatelogs

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Hammond <ahammond(at)ca(dot)afilias(dot)info>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_ctl patch to integrate apache's rotatelogs
Date: 2004-05-20 05:09:27
Message-ID: 200405200509.i4K59Rj12375@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


We documented using rotatelogs in the pg_ctl manual page, and have the
main docs correct on how to use it. Hopefully that will be enough.

---------------------------------------------------------------------------

Andrew Hammond wrote:
[ PGP not available, raw data follows ]
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> |>logrotate rotates log files and hups the servers according to a
> |>configuration file. rotatelogs reads the log data on stdin and reopens
> |>a new output file once in a while. The first hunk of your patch was
> |>wrong, the rest seemed OK.
> |
> |
> | OK, just to confirm, I backed out the first attached patch, but kept the
> | rest, which is my second attached patch.
>
> This looks correct to me.
>
> | I am still confused how these errors remained in the documentation for
> | so long.
>
> Probably because non-syslog logging in a production environment is a
> very small niche. Which might, unfortunately, be a good argument against
> my proposed patch.
>
> Drew
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFAqhIGgfzn5SevSpoRAvizAJ0fZRI5o1FuERzUen2ufWwCsz/J2ACghQ7B
> agaY+YaC0LIVF/jNCk+QnmA=
> =Rsjl
> -----END PGP SIGNATURE-----
>
[ End of raw data]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-05-20 11:34:03 Re: pgkill for windows
Previous Message Bruce Momjian 2004-05-20 04:19:45 Re: Updated FAQ_SCO patch