Re: [COMMITTERS] pgsql-server/src backend/main/main.c b ackend/p

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c b ackend/p
Date: 2004-05-19 23:42:52
Message-ID: 200405192342.i4JNgqW14736@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Claudio Natoli wrote:
>
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > Tom Lane wrote:
> > > >> Also, in the non-exec case it seems unnecessary and possibly unsafe
> to
> > > >> repeat this computation in a backend.
> > >
> > > > Thanks. It originally was as below and I forgot about that. It now
> is:
> > > > if (my_exec_path[0] == '\0' && find_my_exec(argv[0],
> my_exec_path) < 0)
> > > > The issue is that fork/exec will need to set it too.
> > >
> > > That fixes it for my_exec_path, but what of the pkglib_path stuff?
> >
> > OK, I will fix that one, though it is a cheap call.
>
> There's also the possibility of adding it to read/write_backend_variables,
> just as we add other variables for fork/exec that we want the backends to
> inherit.

In the exec case, the executable name is actually different from the
postmaster, so passing it doesn't make sense.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-19 23:51:52 Re: [COMMITTERS] pgsql-server/src backend/main/main.c b ackend/p
Previous Message Claudio Natoli 2004-05-19 23:36:07 Re: [COMMITTERS] pgsql-server/src backend/main/main.c b