Re: pg_ctl patch to integrate apache's rotatelogs

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > Ouch. How long has that documentation been wrong? We have
> > > > pointed folks to that section of the docs tons of times, and no
> > > > one mentioned that "logrotate" is really "rotatelogs", and that
> > > > it is missing parameters?
> > > >
> > > > I have applied the following patch to document rotatelogs
> > > > properly.
> > >
> > > I think you just broke it. logrotate and rotatelogs are two
> > > different programs, and AFAIK the existing documentation correctly
> > > described the one that is easier to use with Postgres.
> >
> > Oh, why don't I have logrotate. My system has:
> >
> > rotatelogs - rotate Apache logs without having to kill the
> > server
> >
> > rotatelogs logfile rotationtime [offset]
> >
> > and it says it is Apache's. I must be wrong but can someone explain
> > this?
>
> logrotate rotates log files and hups the servers according to a
> configuration file. rotatelogs reads the log data on stdin and reopens
> a new output file once in a while. The first hunk of your patch was
> wrong, the rest seemed OK.

OK, just to confirm, I backed out the first attached patch, but kept the
rest, which is my second attached patch.

I am still confused how these errors remained in the documentation for
so long.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073