Re: win32 build and test issues

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: win32 build and test issues
Date: 2004-05-02 18:22:27
Message-ID: 200405021822.i42IMRe15552@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches


Andrew, can you illustrate to the group the exact difference in output?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
> I have tried very hard to work out why this patch works for the
> regression tests in MINGW/MSys, but it doesn't make any sense why this
> one call should add an extra blank line. Does anyone have any bright
> ideas? I'm reluctant to say I think we should apply it until the problem
> is understood and the behaviour explained. But it does appear to work.
>
> cheers
>
> andrew
>
>
>
> >>>>Index: print.c
> >>>>===================================================================
> >>>>RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/print.c,v
> >>>>retrieving revision 1.46
> >>>>diff -c -w -r1.46 print.c
> >>>>*** print.c 24 Jan 2004 20:43:26 -0000 1.46
> >>>>--- print.c 30 Apr 2004 16:44:46 -0000
> >>>>***************
> >>>>*** 388,394 ****
> >>>>--- 388,396 ----
> >>>> for (ptr = footers; *ptr; ptr++)
> >>>> fprintf(fout, "%s\n", *ptr);
> >>>>
> >>>>+ #ifndef WIN32
> >>>> fputc('\n', fout);
> >>>>+ #endif
> >>>>
> >>>> /* clean up */
> >>>> free(cell_w);
> >>>>
> >>>>
> >>>>
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Andrew Dunstan 2004-05-02 18:36:44 Re: win32 build and test issues
Previous Message Bruce Momjian 2004-05-02 18:16:40 Re: Timezone database questions

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-05-02 18:36:44 Re: win32 build and test issues
Previous Message Andrew Dunstan 2004-05-02 17:52:57 Re: win32 build and test issues