Re: Plan for CSV handling of quotes, NULL

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Plan for CSV handling of quotes, NULL
Date: 2004-04-15 02:27:52
Message-ID: 200404150227.i3F2Rqq21224@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
> I talked to Andrew on IRC and we went over the open CSV issues.
>
> We talked about how we could do quoting for zipcode in TEXT fields and
> not quote true numeric values without hardcoding datatypes into the
> system. The most tricky case was NUMERIC vs. TEXT with zipcodes.
> NUMERIC and TEXT have almost identical pg_type entries, so there is
> nothing there to help us.
>
> I found parse_coerce.c::TypeCategory(), which contains information about
> which data type oids are in which grouping, e.g. DATETIME, STRING,
> NUMERIC, etc. It seems that function, if called with
> pg_type.typbasetype could help determine if quotes should be used. My
> idea is to skip quotes for NUMERIC and DATETIME types, and quote
> everything else. This means that user-defined types will always be
> output with quotes, which is probably OK.
>
> So, for open CSV items we have:
>
> o add oid dump/reload
> o handle loading of comma-comma into NOT NULL collumns
> o handle quoting of TEXT type with zipcodes, etc.

Oh, one more item. CSV needs a way to output date values in Datestyle
format, for use by spreadsheets that understand mm/dd/yy dates, but not
ISO dates. This will not be on by default.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-04-15 04:03:46 Re: Plan for CSV handling of quotes, NULL
Previous Message Bruce Momjian 2004-04-14 22:51:44 Plan for CSV handling of quotes, NULL