Re: [HACKERS] logging statement levels

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] logging statement levels
Date: 2004-04-06 21:21:01
Message-ID: 200404062121.i36LL1P27297@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:
> >>I think I'd prefer that to having it tied to the log_min_error_statement
> >>level. But I don't care that much.
> >>
> >>
> >
> >OK, at least we understand each other. Right now we don't have any
> >special "syntax error" log processing. We have errors logged through
> >log_min_error_statement, and mod/ddl through the new log_statement.
> >
> >I can see a use case for having mod/ddl control of logging, and error
> >control of logging, but why would you want to see syntax error queries
> >but not other error queries? That's why I think log_min_error_statement
> >is sufficient. If we add syntax logging,Thinks wouldn't that conflict with
> >log_min_error_statement logging, because those are errors too. Maybe we
> >need to add a 'synax' mode to log_min_error_statement above error that
> >logs only syntax errors but not others.
> >
> >
> >
>
> Thinks .... experiments .... yes, OK, I agree. Please forgive any
> denseness. Not sure if we need another level.

No problem. It is good to think through these things to make sure we
have everything covered.

> Why do we have log_min_error_statement default to PANIC level? Wouldn't
> ERROR be a better default?

Panic basically means off, meaning we don't print queries that generate
errors. Should we print them by default?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-04-06 21:40:12 Re: Abstract for my replication system
Previous Message Dann Corbit 2004-04-06 21:14:54 Small suggestion on build script

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-04-06 22:09:36 Re: [PATCHES] logging statement levels
Previous Message Bruce Momjian 2004-04-06 20:33:43 Re: client_encoding in dump file