Re: pstrndup()

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pstrndup()
Date: 2004-03-22 07:05:28
Message-ID: 20040322070528.GB9385@zf.jcu.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sun, Mar 21, 2004 at 11:45:18PM -0500, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Karel, do you plan to use pstrndup for some purpose? I assume so.

I think PostgreSQL should supports basic operation with
allocation/strings if it's open for users' C functions and we expect
our own memory system usage.

> I am not familiar with strndup. If the spec is like strncpy, I would
> vote against including it ... strncpy is so broken that we had to invent
> our own variant ...

POSIX strncpy() is different, a result from strncpy needn't be zero
terminated. You're right it's horrible function.

The result of strndup() is always zero terminated. It's more safe and
strndup() is binary safe because it doesn't check something in input
string. The pstrndup() is based on PostgreSQL memory managment.

Karel

--
Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
http://home.zf.jcu.cz/~zakkr/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Fabien COELHO 2004-03-22 08:40:54 Re: Syntax error reporting (was Re: [PATCHES] syntax error position
Previous Message Manfred Spraul 2004-03-22 06:12:59 Re: [HACKERS] libpq thread safety