Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads
Date: 2004-03-19 15:15:56
Message-ID: 200403191515.i2JFFvO16584@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> [moved to -patches because of the patch]
>
>
> --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian
> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>
> > Larry Rosenman wrote:
> >> > I thought that once you include libpthread in libpq, that you don't
> >> > have to mention it again then you use libpq. Is your platform
> >> > different somehow in this regard?
> >> >
> >> > I seem to remember this problem with libcrypt and libpq. Is this the
> >> > same problem?
> >> >
> >> > I see that initdb is just the first of many /bin programs to be
> >> > compiled, so if we have to add the thread lib, we will have to do it
> >> > for all the bin programs. Yikes. Why wasn't this a problem for 7.4?
> >> 7.4 had initdb as a Shell Script.
> >> the 7.4.x libpq didn't have any pthread_* references in it, that I see
> >> on my box.
> >
> > Ah, yes. We added the thread-local storage to handle SIGPIPE. The
> > problem is that initdb isn't the only place. If you comment out initdb
> > from the Makefile in src/bin, does the next make fail too? I bet it
> > does.
>
> Apparently, because of the way the wrappers work, having -lpthread on
> libpq.so does NOT add it to the NEEDED list.
>
> I made the following patch, and all compiles now:

Yes, I was afraid of that. Is there any way to make it work? If not,
evey libpq program you create will need -lpthread added.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Larry Rosenman 2004-03-19 15:18:02 Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use
Previous Message Fabien COELHO 2004-03-19 15:09:31 Re: syntax error position "CREATE FUNCTION" bug fix

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2004-03-19 15:18:02 Re: [HACKERS] UnixWare/CVS Tip/initdb.c needs to use
Previous Message Fabien COELHO 2004-03-19 15:09:31 Re: syntax error position "CREATE FUNCTION" bug fix