Re: [HACKERS] Index creation takes for ever

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Manfred Koizar <mkoi-pg(at)aon(dot)at>, pgsql-patches(at)postgresql(dot)org, ohp(at)pyrenet(dot)fr, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Index creation takes for ever
Date: 2004-03-17 17:02:11
Message-ID: 200403171702.i2HH2BI05636@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Where was it posted anyway?
>
> > Found it:
>
> > http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&selm=200312010450.hB14ovH16330%40candle.pha.pa.us&rnum=8
>
> Thanks. The original patch is much older than I thought --- I was
> looking in the November/December part of the archives.
>
> > Personally, because frequently accessed duplicates appear more forward
> > in the duplicate index, I think the sorting is only valuable when
> > creating a new index.
>
> Yes, and that's what this does. Looking back, the original discussion
> got a little confused because the TODO item about "order duplicate index
> entries by tid" got brought into the mix. Actually this patch has
> nothing to do with that, because it only acts during btree creation not
> during index updates.
>
> On inspection I have no problem with the patch, only with the comments ;-)
> If you like I'll revise the comments and apply.

Great. Seems harmless and he showed good performance with it. I agree
the discussion got confused, and that is why I kept it in my mailbox to
revisit.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-03-17 17:03:35 Re: Constraints & pg_dump
Previous Message Renê Salomão 2004-03-17 16:54:03 unsubscribe pgsql-docs

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-03-18 04:02:30 ALTER TABLE...SET WITHOUT CLUSTER
Previous Message Tom Lane 2004-03-17 16:36:59 Re: [HACKERS] Index creation takes for ever