Re: Further thoughts about warning for costly FK checks

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Further thoughts about warning for costly FK checks
Date: 2004-03-15 18:57:45
Message-ID: 200403151057.45860.josh@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard, Tom:

> > > Call me crazy, but maybe we have to throw a message for primary
> > > key lookups on foreign key tables without indexes. I hate to throw a
> > > message on update/delete rather than create table, but I don't see
> > > another way.

You're crazy. For one thing, there are sometimes reasons to *not* have such
an index, and I really don't want a message I can't turn off thinking it
knows how to design a database better than me. Second, many applications
will take warnings on update as an error condition and abort; this would be
fatal to them.

> > I don't think that will fly. It's too noisy/repetitive, and it's
> > complaining at the wrong time (in production rather than when you're
> > setting up the DB schema). Imagine how annoying it would be to get
> > such warnings if you were a user without the privileges needed to create
> > the requested index.

Not to water down anyone's beer, but I'm personally wondering how much good
any of these warnings will do, on CREATE TABLE or ADD CONSTRAINT or
otherwise. I already get 2-4 warnings whenever creating a new table due to
keys, etc. I don't read them anymore unless one of them is an ERROR, and I
suspect that a lot of DBAs are the same.

--
Josh Berkus
Aglio Database Solutions
San Francisco

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-03-15 19:22:32 WAL write of full pages
Previous Message Josh Berkus 2004-03-15 18:52:15 Re: listening addresses