Re: contrib/xml2 function name change and minor bitrot

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, John Gray <jgray(at)azuli(dot)co(dot)uk>, pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/xml2 function name change and minor bitrot
Date: 2004-03-14 03:18:43
Message-ID: 200403140318.i2E3Ihb23081@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > A few comments on the module:
>
> > - can you include some licensing information? "Distributed under the
> > same terms as PostgreSQL, Copyright ..." should be sufficient unless
> > you'd prefer another license
>
> Actually, it had better be "same terms"; we are going to start being
> picky about that for contrib modules. (I have a TODO I've been ignoring
> to try to bring the existing contrib modules into line.)

I have updated both README's to say it has the same BSD copyright as
PostgreSQL.

> > - the readme for both 'contrib/xml' and 'contrib/xml2' is called
> > 'README.pgxml', yet neither module is actually named 'pgxml'
>
> The readmes *must* have different filenames so that they can be
> installed without conflict. It'd probably be best to ensure that they
> match the contrib module names. Are there any other installable files
> in the two modules that have conflicting names?

I have renamed the README's to README.xml and README.xml2 to match /contrib
directory names.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-03-14 03:26:28 Re: PSQLRC environment variable.
Previous Message Bruce Momjian 2004-03-14 01:29:00 Re: ECPG: Update tests & memory leak fix