| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, "'pgsql-hackers-win32(at)postgresql(dot)org'" <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: Win32 regression test status |
| Date: | 2004-03-08 19:21:04 |
| Message-ID: | 200403081921.i28JL4118502@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers-win32 |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Uh, I think you just add ORDER BY to the query and see if the output now
> > matches the regression test. If so, submit a patch to add the ORDER BY.
>
> I'd really prefer not to add ORDER BY to all the join tests, as that
> would restrict the set of join plan types being tested.
Agreed, we don't add them to all joins, but don't we historically add
ORDER BY to queries that are shown to be sensitive to qsort
implementations on various platforms? Are you suggesting we create a
separate regression output file for that platform?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-03-08 19:26:55 | Re: Win32 regression test status |
| Previous Message | Tom Lane | 2004-03-08 18:38:52 | Re: Win32 regression test status |