From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Manfred Spraul <manfred(at)colorfullife(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PQinSend question |
Date: | 2004-02-10 15:20:59 |
Message-ID: | 200402101520.i1AFKxb20064@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Manfred Spraul wrote:
> From fe-secure.c:
>
> > /*
> > * Indicates whether the current thread is in send()
> > * For use by SIGPIPE signal handlers; they should
> > * ignore SIGPIPE when libpq is in send(). This means
> > * that the backend has died unexpectedly.
> > */
> > pqbool
> > PQinSend(void)
> > {
> > #ifdef ENABLE_THREAD_SAFETY
> > return (pthread_getspecific(thread_in_send) /* has it been
> > set? */ &&
> > *(char *)pthread_getspecific(thread_in_send)
> > == 't') ? true : false;
> > #else
> > return false; /* No threading, so we can't be in send() */
>
> Why not? Signal delivery can interrupt send() even with single-threaded
> users.
[ Sorry I am late replying to this.]
I have added the attached comment to CVS to more clearly describe why we
are returning false from PQinSend().
> I really like the openssl interface: what about something like
>
> typedef void (*pgsigpipehandler_t)(bool enable);
>
> void PQregisterSignalCallback(pgsigpipehandler_t new);
>
> The callback is global, and called around the send() calls.
> The default handler uses the sigaction code from 7.4. The current
> autodetection code is less flexible than a callback, and it's not 100%
> backward compatible.
I think I addressed this and it is backward compatible (thread-local
storage), and requires no user application changes.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 1000 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-02-10 15:21:42 | Re: PQinSend question |
Previous Message | Bruce Momjian | 2004-02-10 15:16:14 | Re: [PATCHES] Current-stream read for psql's \copy |