Re: [PATCHES] WIP patch - INSERT-able log statements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Smith <gsmith(at)gregsmith(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] WIP patch - INSERT-able log statements
Date: 2007-02-20 05:14:18
Message-ID: 20035.1171948458@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> The arguments for COPY are performance and that you don't need to specify
> the table name. INSERT is slower and you need a name, but it's easier to
> build a UNIX tool style pipeline to import it in real-time.

I can't believe that any production situation could tolerate the
overhead of one-commit-per-log-line. So a realistic tool for this
is going to have to be able to wrap blocks of maybe 100 or 1000 or so
log lines with BEGIN/COMMIT, and that is exactly as difficult as
wrapping them with a COPY command. Thus, I disbelieve your argument.
We should not be designing this around an assumed use-case that will
only work for toy installations.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message FAST PostgreSQL 2007-02-20 05:44:54 Re: WIP patch - INSERT-able log statements
Previous Message Tom Lane 2007-02-20 04:55:18 Re: Short varlena headers and arrays

Browse pgsql-patches by date

  From Date Subject
Next Message FAST PostgreSQL 2007-02-20 05:44:54 Re: WIP patch - INSERT-able log statements
Previous Message Tom Lane 2007-02-20 05:03:28 Re: [pgsql-patches] Patch to avoid gprofprofilingoverwrites