From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Alpha test |
Date: | 2003-12-23 00:57:14 |
Message-ID: | 200312230057.hBN0vE918520@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > On Mon, Dec 22, 2003 at 06:36:32PM -0500, Bruce Momjian wrote:
> >> Seems we have to test for __alpha and __alpha_. This applied patch
> >> makes that consistent.
>
> > Won't something like the following work?
>
> > #ifdef(__alpha)
> > #define __alpha__ 1
> > #endif
>
> It seems risky to me to define macros that are in the
> reserved-for-system-use namespace. Who knows what might break in the
> system headers if we did that?
I see we already do this in solaris.h:
#if defined(__i386) && !defined(__i386__)
#define __i386__
#endif
#if defined(__sparc) && !defined(__sparc__)
#define __sparc__
#endif
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-12-23 03:31:08 | Move slock_t defines into s_lock.h |
Previous Message | Tom Lane | 2003-12-23 00:41:02 | Re: Alpha test |