Re: [BUGS] pg_service.conf ignores dbname parameter

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Michael Fuhr <mfuhr(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] pg_service.conf ignores dbname parameter
Date: 2003-12-19 21:52:27
Message-ID: 200312192152.hBJLqSX08103@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Regardless of this particular issue, I think it would be useful if,
> > under some conditions to be identified, some service were taken as
> > default if nothing is specied in libpq. That would eliminate the need
> > to set environment variables, which is undesirable in many situations.
>
> That's a thought. Maybe if pg_service.conf exists and contains a
> section named "default", we use whatever settings are present there?
> (Obviously we'd not want the dbname to be forced by this, but I think
> we've already agreed to get rid of that behavior.)
>
> About the only downside I can see to this is that every connection
> would incur the overhead of an attempted file opening. That might be
> thought to be too much overhead, at least by people who have no use
> for the feature. But in comparison to what will happen on the server
> side during backend startup, it's probably pretty negligible.
>
> BTW, why is it that pg_service.conf is system-wide? Personally I'd
> think it more useful to seek settings in ~/.pg_service.conf.

Perhaps the solution is to allow an environment variable to point to the
services file. That way, you only look for the file if that variable
exists. This would also have to be defined for any service file usage,
so maybe this is bad.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PostgreSQL Bugs List 2003-12-19 21:55:13 BUG #1022: date calculation forces wrong type in function parameter and causes error
Previous Message Bruce Momjian 2003-12-19 21:50:31 Re: pg_service.conf ignores dbname parameter

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-12-19 23:11:27 Re: [BUGS] pg_service.conf ignores dbname parameter
Previous Message Bruce Momjian 2003-12-19 21:50:31 Re: pg_service.conf ignores dbname parameter