Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: ViSolve Open Source Team <opensrc_support(at)visolve(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, peter_e(at)gmx(dot)net
Subject: Re: [BUGS] (Modified) Patch request for PostgreSQL 7.4 for
Date: 2003-12-09 23:26:33
Message-ID: 200312092326.hB9NQXh18605@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

ViSolve Open Source Team wrote:
> Bruce,
>
> Thanks for the comments/questions. A couple of points in response:
>
> 1. About the #if defined (_HP_aCC) || defined (_HP_cc)
>
> We agree. That line can go.

OK.

> 2. About the TMPFILE definition change from .c to .h: Unfortunately, the -V option does not work the same way across HP compilers (it works as expected with HP aCC, but not with HP cc).
>
> We have a couple of alternatives here.
>
> a. Using `uname` (to look for HP-UX) and checking to see if $CPP is set to /usr/bin/cc or /opt/aCC/bin/aCC. Not good.
> b. Doing nothing. The TMPFILE mod is a trivial change to make with each new version of PostgreSQL that we build for HP-UX. (We had in fact suggested this in our original request email). So if you make no changes to the TMPFILE code, that will be fine too.

Shame that there is no clean solution. Shame there some output from -V
that would identifity it as the HPUX compiler. I am not worried about
your making a custom version, but buy folks who download the community
release and get failures. Well, I guess we will just wait and see how
often it happens.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-12-09 23:28:20 Re: ISO 8601 'Time Intervals' of the 'format with time-unit
Previous Message Kurt Roeckx 2003-12-09 21:14:47 on_proc_exit/on_shmem_exit prototypes.