Re: Bug fix for 7.4?

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug fix for 7.4?
Date: 2003-11-10 20:30:56
Message-ID: 20031110203056.GA9568@feivel.fam-meskes.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 10, 2003 at 10:50:30AM -0500, Tom Lane wrote:
> I looked over it, and the only part that seems odd is that you seem to
> have removed the type info caching behavior in execute.c. Is that
> intended? It looks like ECPGis_type_an_array() will now issue a query

Well actually no. I removed it for testing reasons but didn't re-add.

> on every call for a non-built-in type, which seems rather a large loss.
> Also, if cache_head ever becomes non-null then it stops trusting its
> internal knowledge as well, which seems worse.

I re-added it.

Memo to /me: Just testing it is not enough. Better to look over the code
again after a night of sleep.

Thanks a lot.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-11-10 20:36:36 Re: Experimental patch for inter-page delay in VACUUM
Previous Message Marc G. Fournier 2003-11-10 20:27:53 Re: [7.3.x] function does not exist ... ?