| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Rod Taylor <pg(at)rbt(dot)ca>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: $PostgreSQL$ header -- Post 7.4 Release |
| Date: | 2003-11-10 19:41:34 |
| Message-ID: | 200311101941.hAAJfZP00826@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Neil Conway wrote:
> Rod Taylor <pg(at)rbt(dot)ca> writes:
> > In src/backend/utils/adt/inet_net_ntop.c and
> > src/backend/utils/adt/inet_net_pton.c it would appear that the $Id$ tag
> > is assigned to a variable (rcsid).
>
> ... which is never referenced AFAICT, even if the necessary
> preprocessor definitions are set so that it is seen by the compiler in
> the first place. Is there a reason not to remove this code from both
> files?
OK, removed with attached patch. (CVS will update the file name.)
It is a BSD source code style that isn't used by our code.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-11-10 23:02:32 | Re: [PATCHES] initdb in C |
| Previous Message | Neil Conway | 2003-11-10 19:29:48 | Re: $PostgreSQL$ header -- Post 7.4 Release |