Re: [HACKERS] BEGIN vs START TRANSACTION

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Gaetano Mendola <mendola(at)bigfoot(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] BEGIN vs START TRANSACTION
Date: 2003-11-10 16:20:43
Message-ID: 200311101620.hAAGKhK26962@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Jan Wieck wrote:
> Bruce Momjian wrote:
>
> > Tom Lane wrote:
> >> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> > Peter Eisentraut wrote:
> >> >> I object to adding unnecessary complications like that.
> >>
> >> > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The
> >> > changes to the code were the addition of only one line. The rest of the
> >> > patch was docs.
> >>
> >> My initial reaction was the same as Peter's, but after seeing the small
> >> size of the patch I reconsidered. It seems to make sense that BEGIN
> >> should be an exact synonym for START TRANSACTION.
> >
> > Let me give you my logic on this --- if people think of BEGIN and START
> > TRANSACTION as the same, and they do \h begin, they aren't going to see
> > the read only and isolation options for START TRANSACTION, and I doubt
> > they are going to think to look there because they think they are the
> > same. That's why I think it is good to add those clauses to BEGIN
> > WORK/TRANSACTION.
> >
>
> Since BEGIN isn't standard, wouldn't it be time to redirect them on the
> BEGIN manpage to the START TRANSACTION manpage and tell them there that
> BEGIN does not support the full syntax of START TRANSACTION?

Yea, we could do that, and if it was hard to add, we would, but it seems
easier to just say BEGIN and START TRANSACTION are the same except the
later is standard, rather than have the later have additional
functionality too.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-11-10 16:23:20 Re: [HACKERS] BEGIN vs START TRANSACTION
Previous Message scott.marlowe 2003-11-10 16:02:51 Re: Performance features the 4th

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-11-10 16:23:20 Re: [HACKERS] BEGIN vs START TRANSACTION
Previous Message Jason Tishler 2003-11-10 16:19:07 Re: "make check" improvement for cygwin