Re: [HACKERS] BEGIN vs START TRANSACTION

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Gaetano Mendola <mendola(at)bigfoot(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] BEGIN vs START TRANSACTION
Date: 2003-11-10 03:10:47
Message-ID: 200311100310.hAA3Al428467@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Peter Eisentraut wrote:
> >> I object to adding unnecessary complications like that.
>
> > Shouldn't BEGIN and START TRANSACTION have the same mechanics? The
> > changes to the code were the addition of only one line. The rest of the
> > patch was docs.
>
> My initial reaction was the same as Peter's, but after seeing the small
> size of the patch I reconsidered. It seems to make sense that BEGIN
> should be an exact synonym for START TRANSACTION.

Let me give you my logic on this --- if people think of BEGIN and START
TRANSACTION as the same, and they do \h begin, they aren't going to see
the read only and isolation options for START TRANSACTION, and I doubt
they are going to think to look there because they think they are the
same. That's why I think it is good to add those clauses to BEGIN
WORK/TRANSACTION.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-11-10 03:29:32 Re: Erroneous PPC spinlock code
Previous Message Kris Jurka 2003-11-10 01:59:02 Re: Setting client encoding with jdbc

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-11-10 03:18:11 Re: [HACKERS] Bug fix for 7.4?
Previous Message Stephan Szabo 2003-11-09 18:02:56 Small Doc Patch