Re: psql tab completion bug and possible fix

On Wednesday 15 October 2003 22:45, Tom Lane wrote:
> Ian Barwick <barwick(at)gmx(dot)net> writes:
> > On Tuesday 14 October 2003 23:38, Tom Lane wrote:
> >> Surely all those replacements of \\ with \\\\ are wrong.
> >
> > The slash in the slash command gets escaped too...:
>
> Not the way I did it. You were doing the escaping in the wrong place
> IMHO --- the string passed to _complete_from_query() mustn't be escaped
> already, because it is not only used to send a command to the backend,
> but also to compare against the strings returned by the backend, which
> won't be escaped. So the escaping needs to be done internally to
> _complete_from_query(), and that eliminates the side-effects elsewhere.

Aha, sorry, I hadn't seen your patch. It works excellently for me, so
I shall gripe no longer ;-).

Many thanks

Ian Barwick
barwick(at)gmx(dot)net