From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PG Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: fix for strict-alias warnings |
Date: | 2003-10-13 00:17:46 |
Message-ID: | 200310130017.h9D0Hkn04642@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> Andrew Dunstan wrote:
> >
> > ----- Original Message -----
> > From: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
> > >
> > > I have backed out the patch.
> > >
> > > Looking at the case in tablecmds.c and proc.c, the first was assigning a
> > > struct with a NodeTag pointer as its first element to another struct
> > > with NodeTag as its first element. In fact, we do this all over the
> > > place, having different structure pointers with a start element of
> > > NodeTag.
>
> I have attached and applied the following patch to use makeNode for
> structures that will later be cast to Node*, rather than having them be
> allocated as stack variables.
Oh, and thanks to everyone for doing the research on this compiler issue.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2003-10-13 00:39:27 | Re: fix for strict-alias warnings |
Previous Message | Bruce Momjian | 2003-10-12 23:18:43 | Re: fix for strict-alias warnings |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2003-10-13 00:39:27 | Re: fix for strict-alias warnings |
Previous Message | Bruce Momjian | 2003-10-12 23:18:43 | Re: fix for strict-alias warnings |