| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PG Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: fix for strict-alias warnings |
| Date: | 2003-10-11 17:13:46 |
| Message-ID: | 200310111713.h9BHDkY20385@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Patch applied. Thanks.
>
> I hope you applied it with the additional changes you asked for ---
> at the very least, cast to (void*) and then to the destination type.
> As-is, the patch simply suppresses all error detection for these
> conversions, which seems a bad move.
I don't have a version that does the double-cast, but I still have the
patch to back out and put in a new one. Andrew's point was that we cast
to void * in many places, so this case is not unique. Is that wrong?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Karppinen | 2003-10-11 17:28:20 | Re: Hacking PostgreSQL to work in Mac OS X 10.3 (Panther 7B85) |
| Previous Message | Tom Lane | 2003-10-11 17:02:53 | Re: fix for strict-alias warnings |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-10-11 17:29:07 | Re: fix for strict-alias warnings |
| Previous Message | Tom Lane | 2003-10-11 17:02:53 | Re: fix for strict-alias warnings |