Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)rbt(dot)ca>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-05 22:14:45
Message-ID: 200310052214.h95MEjf11099@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Rod Taylor wrote:
-- Start of PGP signed section.
> > Probably pretty long. I think the pg_stat_activity case really needs
> > the "\n" because if not the query breaks the table output format. Not
>
> I was actually thinking exactly the opposite. pg_stat_activity viewed in
> pgadmin GUI is going to format the table perfectly fine, but with
> everthing on one line it will be next to impossible to understand
> anything complex.

You are right. It is psql that is at fault for causing the \n value to
start at the beginning of the next line and not at the proper column on
the next line. I will not change the pg_stat_activity values.

Tom's idea of doing it in elog is better, of course.

> I would imagine psql will also be easier to read using human placed \n's
> rather than random ones at the terminal width.

Right.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-10-05 22:20:51 Re: fix log_min_duration_statement logic error
Previous Message Peter Eisentraut 2003-10-05 21:53:01 Re: Russian NLS update: pg_dump, libpq, psql