From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Rod Taylor <rbt(at)rbt(dot)ca>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: fix log_min_duration_statement logic error |
Date: | 2003-10-05 21:18:27 |
Message-ID: | 200310052118.h95LIRZ05716@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Another example:
> > LOG: duration: 4.228 ms; select *\nfrom pg_language;
>
> Minor quibble: would it read better as
>
> LOG: duration n.nnn ms: query
> or
> LOG: duration n.nnn ms for query
I like it:
LOG: duration: 4.056 ms for select * \nfrom pg_language;
Another idea if you like consistency would be:
LOG: duration: 4.056 ms query: select * \nfrom pg_language;
Patch for "query:" version attached.
Do I need to pfree the memory returned by str_make_symbolic_eol() or is
that cleaned up automatically?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 9.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-10-05 21:19:39 | Re: Open 7.4 items |
Previous Message | Tom Lane | 2003-10-05 21:11:29 | Re: Open 7.4 items |