Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-05 17:42:21
Message-ID: 200310051742.h95HgLR10949@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Tom Lane writes:
> >> BTW, EXPLAIN ANALYZE puts out
> >> Total runtime: 406.53 msec
> >> Do you want to make an exception to the string freeze to change this
> >> to "ms"?
>
> > I just realized, all the things that are sent as a query result instead of
> > an error or notice are not gettext-enabled. I guess we'll have to do
> > without that in this release. So, making the above change does not pose a
> > problem.
>
> Okay, I'll make that change. Any opinions about the 2-vs-3-digit issue?

I think three is the only reasonable number --- when you are in digits
to the right of the decimal, it should be grouped by three. To group
by two makes it look like a US dollar amount, and I can't see a rational
for two digits.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-10-05 17:44:32 Re: fix log_min_duration_statement logic error
Previous Message Tom Lane 2003-10-05 17:40:44 Re: fix log_min_duration_statement logic error