Re: pg_dump no longer honors --no-reconnect

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump no longer honors --no-reconnect
Date: 2003-09-29 13:49:58
Message-ID: 200309291349.h8TDnwZ08561@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Seems we can silently ignore a --use-set-session-authorization flag
> > because that is now the default, but I don't see how we can ignore a
> > --no-reconnect flag --- we should throw an error.
>
> Why? The new bevavior of pg_dump is to never reconnect -- exactly the
> point of this change.

Oh, sorry, I see now. I got --no-reconnect confused with --reconnect,
which would say we want to reconnect. I now see the option handling is
fine because we do both by default.

> > Also, the 7.3 manual mentions that only the super-user can restore using
> > --use-set-session-authorization. This is now the only way to create
> > dumps. Seems this is a new limitation to pg_dump that we didn't
> > discuss.
>
> It had been dicussed on and off for quite some time. This limitation
> should only apply if you create dumps that contain objects owned by more
> than one user. (Does it? I didn't check.)

Yes, but didn't the old code prompt you for passwords, or silently work
if you had things set to 'trust', while our new code requires
super-user?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2003-09-29 13:53:13 Re: ADD FOREIGN KEY (was Re: [GENERAL] 7.4Beta)
Previous Message Bruce Momjian 2003-09-29 13:47:43 Re: pg_get_ruledef and extra line breaks