From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | "Nigel J(dot) Andrews" <nandrews(at)investsystems(dot)co(dot)uk> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: old pgindent change |
Date: | 2003-09-28 00:25:44 |
Message-ID: | 200309280025.h8S0PiE27079@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Great. Patch applied. Nice to see someone else using pgindent.
---------------------------------------------------------------------------
Nigel J. Andrews wrote:
>
> On Mon, 22 Sep 2003, Nigel J. Andrews wrote:
>
> >
> > There was a simple change commited in revision 1.47 of pgindent, listed as
> > being "More updates for GNU indent".
> >
> > The questions are: why? and surely I can't be the only one whose hit this
> > problem since November 2001?
> >
> > ...
>
> I also had to apply the following change in order to avoid an awk compilation
> error:
>
> *** pgindent Mon Sep 22 23:54:40 2003
> --- pgindent.new Mon Sep 22 23:54:27 2003
> ***************
> *** 65,71 ****
> line1 !~ "^typedef" &&
> line1 !~ "^extern[ ][ ]*\"C\"" &&
> line1 !~ "=" &&
> ! line1 ~ ")")
> print "int pgindent_func_no_var_fix;";
> line1 = line2;
> }
> --- 65,71 ----
> line1 !~ "^typedef" &&
> line1 !~ "^extern[ ][ ]*\"C\"" &&
> line1 !~ "=" &&
> ! line1 ~ "\)")
> print "int pgindent_func_no_var_fix;";
> line1 = line2;
> }
>
>
> The changed line was also added in November 2001, in revision 1.48 this time.
>
> awk -W version
> mawk 1.3.3 Nov 1996, Copyright (C) Michael D. Brennan
>
> and again with /bin/sh being a link to bash 2.03.0
>
>
> --
> Nigel J. Andrews
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-09-28 01:14:28 | Re: [COMMITTERS] pgsql-server/src/backend/executor execScan.c |
Previous Message | Bruce Momjian | 2003-09-28 00:21:48 | Re: old pgindent change |