Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-09-27 23:52:57
Message-ID: 200309272352.h8RNqvD25042@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


> I think there should be just one "duration: nnn" log entry, printed if
> either condition holds.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > I also don't particularly like the format of the log message (for one
> > thing, the "duration_statement" prefix in the log message shouldn't
> > include an underscore, it's not a variable or anything -- and the case
> > can be made that if we printed the duration because log_duration is set,
> > we don't need to print it again if the duration of the query exceeded
> > log_min_duration_statement), but I haven't changed it.
>
> I think there should be just one "duration: nnn" log entry, printed if
> either condition holds.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2003-09-28 00:02:17 Re: bug in clusterdb script
Previous Message Bruce Momjian 2003-09-27 23:52:41 Re: fix log_min_duration_statement logic error