free(3)-ing variables in pg_dump

From: Andreas Joseph Krogh <andreak(at)officenet(dot)no>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: free(3)-ing variables in pg_dump
Date: 2003-09-23 13:41:38
Message-ID: 200309231541.38827.andreak@officenet.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi.

I'm trying to implement functionallity to dump multiple tables with multiple
"-t <table-name>" options. While digging in the source for pg_dump I see that
many local static variables are not freed( with free(3)). Is this lazy
programming because pg_dump is its own process where the kernel takes care
of cleaning up, so you don't bother to do it for some of the variables? I'm
malloc'ing some structs to build a list over tables which are marked for
dumping. Shall I bother to free(3) them?

- --
Andreas Joseph Krogh <andreak(at)officenet(dot)no>
Managing Director, Senior Software Developer
OfficeNet AS

- - Writing software is more fun than working.

gpg public_key: http://dev.officenet.no/~andreak/public_key.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/cE2SUopImDh2gfQRAhOxAJ0Wr7s98ufN4BEckpVem/tFfekIwQCghS+3
8x/TV1Oqx++ywYDyOJxQSCU=
=uKgq
-----END PGP SIGNATURE-----

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhen Yang 2003-09-23 14:02:54 Question on adding new indexes to Postgresql
Previous Message jasongodden 2003-09-23 12:40:49 Re: Building from CVS issues