Re: some strange messages

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some strange messages
Date: 2003-09-15 19:14:57
Message-ID: 20030915191457.GH4405@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 15, 2003 at 01:28:52AM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:

> > #: utils/adt/acl.c:780
> > msgid "cannot remove the world ACL"
>
> > What exactly is "the world ACL"?
>
> Privileges granted to PUBLIC --- the ACL code always keeps PUBLIC
> privileges as an ACL entry, even when they are empty. I suspect this is
> an internal error that cannot happen unless an upper software layer blew
> it, and as such does not need to be translated. Can anyone check that?
> I'm about out of steam for tonight...

Hmm.. the code is making the assumption that this ACL is at position 0
of the ACL list.

It would be quite nice if this message needs not be translated, because
it's the only message that's left for me currently, and even if I
understand what's about I can't find a good translation.

> > #: parser/gram.y:3249
> > msgid "argument type missing (use NONE for unary operators)"
>
> > Maybe the string between parenthesis should be in a separate errhint() ?
>
> Or rewrite entirely. Do you have a better wording?

Yes. In fact something very similar appears in regproc.c, line 636:

if (nargs == 1)
ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_PARAMETER),
errmsg("missing argument"),
errhint("Use NONE to denote the missing argument of a unary operator.")));

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"El realista sabe lo que quiere; el idealista quiere lo que sabe" (Anonimo)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-09-15 20:07:27 Fixing some pg_dump issues
Previous Message Patrick Welche 2003-09-15 18:55:43 Re: compile warnings in CVS HEAD?