From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, christoph(dot)dalitz(at)hs-niederrhein(dot)de |
Subject: | WIN32_CONSOLE usage |
Date: | 2003-09-07 16:21:41 |
Message-ID: | 200309071621.h87GLfG09745@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-cygwin pgsql-hackers-win32 pgsql-patches |
Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > The problem is that mbvalidate() has this code:
> >
> > if (GetVariableBool(pset.vars, "WIN32_CONSOLE"))
> > CharToOem(pwcs, pwcs);
> >
> > That's why I needed the #ifdef so it only tests from psql. This code
> > was just broken without that test, and because no one else has done
> > Win32 compiles since it was added, no one saw it.
>
> Interesting, considering that WIN32_CONSOLE isn't being set anywhere.
>
> Anyway, that code needs to be removed/fixed, for the mentioned reasons.
Yikes, I see no doc mention of it.
Here is the submission email:
> c) Problem: 8bit characters were displayed/interpreted wrong in psql
> This is due to the fact that the Win32 "console" uses a
> different encoding than the rest of the Windows system
> Solution: Introduced a new psql variable WIN32_CONSOLE
> When set with "\set WIN32_console", the function OemToChar()
I have CC'ed the author.
Is this a valid feature? Should I document it?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2003-09-07 16:29:42 | Re: WIN32_CONSOLE usage |
Previous Message | Peter Eisentraut | 2003-09-07 16:08:42 | Re: [PATCHES] MinGW patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2003-09-07 16:29:42 | Re: WIN32_CONSOLE usage |
Previous Message | Peter Eisentraut | 2003-09-07 16:08:42 | Re: [PATCHES] MinGW patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-09-07 16:23:28 | Re: [HACKERS] Index creation takes for ever |
Previous Message | Bruce Momjian | 2003-09-07 16:16:23 | Re: [HACKERS] Index creation takes for ever |