Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Lee Kindness <lkindness(at)csl(dot)co(dot)uk>, "Marc G(dot) Fournier" <scrappy(at)hub(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Date: 2003-09-02 22:32:03
Message-ID: 200309022232.h82MW3R22996@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Larry Rosenman wrote:
> >> >> Bruce Momjian writes:
> >> >> > Right. We can't assume because a *_r function is missing that the
> >> >> > normal function is thread-safe.
> >> >
> >> >> That's not our concern - if the OS isn't thread safe we can't do
> >> >> anything about it, and to worry about it is an enormous waste of
> >> >> development time.
> >> >
> >> > There is a long way between configure not finding a particular *_r
> >> > function and the entire operating system not being thread-safe. There
> >> > are many uncertainties along that way, and I believe my point was that
> >> > the only way we can get a degree of certainty about the result of a
> >> > particular build is that we keep a database of exactly what is
> >> > required for thread-safety on each platform.
> >> Ok, now, is my statement from a SCO Developer good enough to get
> >> thread-safety enabled
> >> on UnixWare with only the getpwuid_r() function?
> >
> > Woh, I thought we just agreed that getpwuid_r() isn't required for
> > thread-safety on your platform.
> it's CLEANER to use it.
>
> Our API Signature is the _r version, why not use it when it's available?

My new patch will optionally use it if it exists, but we still need to
know if it is required so if we don't find it, we throw an error.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Larry Rosenman 2003-09-02 22:33:50 Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Previous Message Darko Prenosil 2003-09-02 22:28:45 libpq makefile for bcc