Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Lee Kindness <lkindness(at)csl(dot)co(dot)uk>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Date: 2003-09-02 21:35:51
Message-ID: 200309022135.h82LZpG17270@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Lee Kindness wrote:
> Bruce Momjian writes:
> > Lee Kindness wrote:
> > > No, it's not. Using the _r functions on such systems is BETTER because
> > > the API is clean and the function can be implmented in a reentrant and
> > > thread-safe fashion wuithout the need for thread local storage or
> > > mutex locking.
> > I don't care about overhead at this point. These functions are rarely
> > called.
>
> Nor do I, but there is no requirement or point in using the
> traditional interface over the _r one then the traditional one is
> known to be thread-safe. It only adds additional complexity.

I am working on a patch that will _prefer_ the *_r functions, but only
fail if not found when the OS is marked as requiring them. At this
point, the only OS so marked is Linux and Unixware (though my patch will
change Unixware to not requiring *_r).

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-02 21:58:50 Re: NOTICE vs WARNING
Previous Message Hannu Krosing 2003-09-02 20:27:58 Re: Win32 native port