Re: to_timestamp not stable if date string shorter than

From: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stacy White <harsh(at)computer(dot)org>, <pgsql-bugs(at)postgresql(dot)org>, Aaron Harsh <ajh(at)rentrak(dot)com>, Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Subject: Re: to_timestamp not stable if date string shorter than
Date: 2003-09-03 04:33:11
Message-ID: 20030902212526.F60896-100000@megazone.bigpanda.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

On Wed, 3 Sep 2003, Tom Lane wrote:

> Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com> writes:
> > Replying to myself again:
> > In DCH_processor (formatting.c), it doesn't seem to stop if it's in the
> > middle of processing nodes but runs off the inout string, should the for
> > loop be something like:
> > for (n=node,s=inout;n->type!=NODE_TYPE_END && *s!='\0';++n,++s) {
> > and get rid of the ++s at the bottom of the loop for safety?
>
> That wouldn't change the behavior, would it?

It would I believe, as soon as it reached a \0 it'd stop the loop, but
checking *s is probably the wrong thing to do when flag==TO_CHAR, so I
think that bailing to Karel is probably the right choice.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Karel Zak 2003-09-03 07:31:23 Re: to_timestamp not stable if date string shorter than
Previous Message Tom Lane 2003-09-03 04:15:47 Re: to_timestamp not stable if date string shorter than

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2003-09-03 05:51:49 Tiny doc improvement
Previous Message Tom Lane 2003-09-03 04:15:47 Re: to_timestamp not stable if date string shorter than