Re: UnixWare on Current CVS: Success!

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: ohp(at)pyrenet(dot)fr, pgsql-hackers(at)postgresql(dot)org
Subject: Re: UnixWare on Current CVS: Success!
Date: 2003-08-25 04:03:43
Message-ID: 200308250403.h7P43hZ06225@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


NP. We will get this fixed. I am still thinking about it, and will do
something when I get to that email.

I am trying to avoid having a template/* variable for each *_r function,
but that may be required. The "try for *_r library and continue if you
can't find it" just seems too risky. We might have to add those three
variables and you set to yes/no in each template file for each platform.

---------------------------------------------------------------------------

Larry Rosenman wrote:
>
>
> --On Sunday, August 24, 2003 23:17:07 -0400 Bruce Momjian
> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>
> >
> > I am working my way through my email to that ***ISSUE*** (*** looks kind
> > of silly, doesn't it). If you are putting those stars there because I
> > am not working on that issue fast enough for you, well ...
> I posted stuff on Friday/Saturday with no comment, as soon as I returned
> from Las Vegas.
>
> So, I'm a little cranky.
>
> Sorry.
>
> LER
>
> >
> > -------------------------------------------------------------------------
> > --
> >
> > Larry Rosenman wrote:
> >>
> >>
> >> --On Sunday, August 24, 2003 22:49:00 -0400 Bruce Momjian
> >> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> >>
> >> >
> >> > OK, I now realized this code is shell script, not Makefile content.
> >> >
> >> > Code changed to:
> >> >
> >> > THREAD_CFLAGS = "$THREAD_CFLAGS -D_REENTRANT"
> >> Ok, but we are **STILL** broke for the --enable-thread-safety flag due
> >> to your commit
> >> requiring all 3 *_r (gethostbyname, strerror, and getpwuid) functions,
> >> even though all
> >> UnixWare has is the getpwuid_r function.
> >>
> >> Please either revert that requirement, or apply a patch to allow
> >> UnixWare to compile with
> >> --enable-thread-safety by making the change to src/port/thread.c to use
> >> a HAVE_GETPWUID_R flag, and arrange for configure to set that flag.
> >>
> >> Thanks,
> >> LER
> >>
> >> >
> >> >
> >> > ----------------------------------------------------------------------
> >> > --- --
> >> >
> >> > Larry Rosenman wrote:
> >> >> Didn't seem to. Did you see my posts from fri/sat on -hackers?
> >> >>
> >> >> I included what DID work for me.
> >> >>
> >> >> LER
> >> >>
> >> >>
> >> >> --On Sunday, August 24, 2003 19:21:57 -0400 Bruce Momjian
> >> >> <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> >> >>
> >> >> > Larry Rosenman wrote:
> >> >> >> On Aug 17 2003, ohp(at)pyrenet(dot)fr wrote:
> >> >> >>
> >> >> >> > Did something changed on today's cvs.
> >> >> >> >
> >> >> >> > src/template/unixware is wrong on last line: THREAD_CFLAGS +=
> >> >> >> > -D_REENTRANT should be THREAD_CFLAGS="$THREAD_CFLAGS
> >> >> >> > -D_REENTRANT"
> >> >> >> No it shouldn't....
> >> >> >>
> >> >> >> The original patch worked just fine...
> >> >> >>
> >> >> >> I'll look when I get back from Forum.
> >> >> >
> >> >> > I changed the define to be:
> >> >> >
> >> >> > THREAD_CFLAGS += "-D_REENTRANT"
> >> >> >
> >> >> > Do the quotations help?
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Larry Rosenman http://www.lerctr.org/~ler
> >> >> Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
> >> >> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> >>
> >>
> >>
> >> --
> >> Larry Rosenman http://www.lerctr.org/~ler
> >> Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
> >> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
> >>
> >>
> >> ---------------------------(end of broadcast)---------------------------
> >> TIP 7: don't forget to increase your free space map settings
>
>
>
> --
> Larry Rosenman http://www.lerctr.org/~ler
> Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
> US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-08-25 04:11:08 Re: Parsing speed (was Re: pgstats_initstats() cost)
Previous Message Larry Rosenman 2003-08-25 03:20:49 Re: UnixWare on Current CVS: Success!