From: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: getting confused parsing ACLITEMS... |
Date: | 2003-08-09 14:39:54 |
Message-ID: | 20030809223921.J96609-100000@houston.familyhealth.com.au |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
OK,
So if you agree that there is a quoting problem,and you don't mind
breaking backwards compatibility for it, I'll do a complete patch...
Chris
On Fri, 8 Aug 2003, Tom Lane wrote:
> "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > The situation seems to be a bug that this patch would address. It seems to
> > me that when a username is considered unsafe due to containing double
> > quotes, the double quotes should be escaped (and the backslashes)!
>
> > Does this look alright?
>
> I would personally say that the convention ought to match what is done
> in quoted identifiers, namely: " becomes "", backslash is not special
> and therefore doesn't need anything.
>
> More to the point, this is highly incomplete... you did not teach the
> adjacent getid routine about this, and there is code in (at least)
> pg_dump.c that knows the quoting conventions used here.
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | Christopher Kings-Lynne | 2003-08-09 14:41:04 | Re: getting confused parsing ACLITEMS... |
Previous Message | Kurt Roeckx | 2003-08-09 14:12:47 | Re: parallel regression test failure |