Re: new compile warning

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Joe Conway <mail(at)joeconway(dot)com>, "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new compile warning
Date: 2003-08-04 02:54:30
Message-ID: 200308040254.h742sU423459@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
> > plpython.c: In function `plpython_call_handler':
> > plpython.c:354: warning: suggest explicit braces to avoid ambiguous `else'
>
> Apparently the Python boys are not familiar with the do {...} while (0)
> trick to ensure that a macro containing C statements won't interact with
> its environment. I'll put back the braces that pgindent removed, but
> someone should file a bug report against Py_DECREF().
>

Good fix. That comment will prevent pgindent from modifying it in the
future.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message snpe 2003-08-04 02:56:24 Re: Release changes
Previous Message Bruce Momjian 2003-08-04 02:51:04 pgindent/copyright update done