Re: Adding Rendezvous support to postmaster

Got it. Thanks for the testing. Patch attached and applied.

---------------------------------------------------------------------------

Chris Campbell wrote:
> OK, compiled and tested. Looks good. One modification to your patch:
> there's a line that says "if (service_name != NULL)" -- that should be
> "if (rendezvous_name != NULL)" since that variable's been renamed.
> Change that, and I'm happy.
>
> Thanks!
>
> - Chris
>
> On Monday, Jul 21, 2003, at 23:50 US/Eastern, Bruce Momjian wrote:
>
> > OK, new patch attached, with the adjustment you suggested. We do
> > probably have a few days to resolve this, but if we run out of time, I
> > will drop it like a hot potato and keep it for 7.5. :-)
> >
> > -----------------------------------------------------------------------
> > ----
> >
> > Chris Campbell wrote:
> >> On Monday, Jul 21, 2003, at 21:17 US/Eastern, Bruce Momjian wrote:
> >>
> >>> Again, why does the current code pass NULL as the first param ---
> >>> that
> >>> was from your orignal patch.
> >>
> >> The original patch passed the service_name variable (which you've now
> >> renamed rendezvous_name) as the first parameter. I'm not sure how that
> >> NULL got there. You're correct: the first parameter is the string to
> >> use as the service name. To use the default (the Computer Name), ""
> >> should be passed (the empty string). Which, if rendezvous_name
> >> defaults
> >> to "", means that rendezvous_name should be passed in all cases.
> >>
> >>> I figure because we have a Rendezvous config param, then they want it
> >>> on
> >>> by default.
> >>
> >> I agree with that thinking. In my original patch, I required that a
> >> "service_name =" directive be in the config file to turn on Rendezvous
> >> service advertisement, and that "service_name = """ be in there to use
> >> the default service name (the Computer Name), but I like this way
> >> better: always advertise a service (if HAVE_RENDEZVOUS is defined) and
> >> use the default service name ("") unless a service name is configured
> >> with rendezvous_name = in the config file.
> >>
> >> I like it. I'll check out your pointers on getting initdb to work in
> >> OS
> >> X, make sure I've got a good looking patch, then mail you a patch to
> >> HEAD. Probably tomorrow? That work?
> >>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073