Re: [HACKERS] sa_family_t in cygwin compile of cvs

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: deststar <deststar(at)blueyonder(dot)co(dot)uk>
Cc: Jason Tishler <jason(at)tishler(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-cygwin(at)postgresql(dot)org
Subject: Re: [HACKERS] sa_family_t in cygwin compile of cvs
Date: 2003-06-18 01:12:56
Message-ID: 200306180112.h5I1Cu509293@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers


I am confused why you didn't like the following patch I posted, which
pulls the family data type length right out of the structure, rather than
having to configure it for every OS that doesn't have sa_family_t?

---------------------------------------------------------------------------

deststar wrote:
> Jason Tishler wrote:
> > On Sun, Jun 15, 2003 at 04:54:21PM +0100, deststar wrote:
> >
> >>On cygwin sa_family_t was undeclared, adding the following line:
> >>typedef unsigned short sa_family_t;
> >>to both:
> >>src/port/getaddrinfo.c
> >>src/include/libpq/pqcomm.h
> >
> >
> > Isn't the attached or fixing Cygwin itself a better approach?
> >
> >
> Yes it does seem better, attached is a proposed patch to cygwin.h &
> configure.in (incase cygwin gets it in future)
> Have tested with make installcheck & it works fine.
> If you see no problems I will sumit to patches
> thanks,

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.5 KB

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Bruno Wolff III 2003-06-18 03:47:37 Re: ss_family in hba.c
Previous Message deststar 2003-06-18 00:09:58 Re: [HACKERS] sa_family_t in cygwin compile of cvs

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2003-06-18 01:39:54 Re: pg_get_triggerdef in pg_dump
Previous Message deststar 2003-06-18 00:09:58 Re: [HACKERS] sa_family_t in cygwin compile of cvs