Re: [HACKERS] PostgreSQL libraries - PThread Support, but

Kurt Roeckx wrote:
> On Sat, Jun 14, 2003 at 02:20:44PM -0400, Bruce Momjian wrote:
> >
> > This patch handles two more gethostbyname calls.
> >
> [...]
> > diff -c -c -r1.24 fe-secure.c
> > *** src/interfaces/libpq/fe-secure.c 14 Jun 2003 17:49:54 -0000 1.24
> > --- src/interfaces/libpq/fe-secure.c 14 Jun 2003 18:08:54 -0000
> > ***************
> > *** 453,460 ****
> > if (addr.sa_family == AF_UNIX)
> > return 0;
> >
> > /* what do we know about the peer's common name? */
> > ! if ((h = gethostbyname(conn->peer_cn)) == NULL)
> > {
> > printfPQExpBuffer(&conn->errorMessage,
> > libpq_gettext("could not get information about host (%s): %s\n"),
>
> That code is inside #ifdef NOT_USED, which is why I didn't change
> it in my ipv6 patch.

Yes, I noticed that, but it seemed reasonable to get things consistent.

>
> Should I convert that function to use getaddrinfo too?
>
> Others I didn't change where pg_krb4_sendauth() and
> pg_krb5_sendauth(), because I don't have a clue about kerberos.

I understand. I guess we should be consisent if we can be.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073