Re: 7.3 and HEAD broken for dropped columns of dropped types

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: 7.3 and HEAD broken for dropped columns of dropped types
Date: 2003-05-11 20:28:47
Message-ID: 20030511202847.GA4893@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 11, 2003 at 04:20:59PM -0400, Tom Lane wrote:

> I am thinking that it might be a good idea for ALTER TABLE DROP COLUMN
> to reset atttypid to zero in the dropped column's pg_attribute row.
> This would help catch any other places that are depending on a dropped
> column's atttypid to still be valid. On the other hand, it would
> possibly confuse applications that are looking at pg_attribute.
> Comments anyone?

Applications looking at pg_attribute and ignoring attisdropped are
broken anyway, so just exposing their brokenness by means of setting an
invalid atttypid does not make them any more (nor any less) broken.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Porque francamente, si para saber manejarse a uno mismo hubiera que
rendir examen... ¿Quién es el machito que tendría carnet?" (Mafalda)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-05-11 22:50:36 Re: 7.3 and HEAD broken for dropped columns of dropped types
Previous Message Tom Lane 2003-05-11 20:20:59 7.3 and HEAD broken for dropped columns of dropped types