Re: rint() replacement

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, meskes(at)postgresql(dot)org
Subject: Re: rint() replacement
Date: 2003-05-10 02:07:56
Message-ID: 200305100207.h4A27uS13956@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
> speaking of rint(), I just got this on Linux on a clean get from CVS:
>
> gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -fpic -I../../../.
> ./src/interfaces/ecpg/include -I../../../../src/include/utils -I../../../../
> src/include -c -o dt_common.o dt_common.c
> dt_common.c: In function `dt2time':
> dt_common.c:1271: warning: implicit declaration of function `rint'
>
> which I guess is kinda undesirable...

OK, fixed. I added '#include <math.h>'.

However, this illustrates another problem. dt_common and other ecpg
files test for c.h defines but there is no #include of c.h or
postgres.h, so they never get triggered. That needs to be fixed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-05-10 02:10:51 Re: rint() replacement
Previous Message Andrew Dunstan 2003-05-09 21:41:37 Dev FAQ emacs settings