From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Win32 defines |
Date: | 2003-04-16 14:51:55 |
Message-ID: | 200304161451.h3GEptx06597@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Why is this removing the use of the TIMEZONE_GLOBAL macro?
It was Peter's suggestion. Once we had a port-specific define, we
should use timezone directly, no?
---------------------------------------------------------------------------
> Index: src/include/utils/datetime.h
> ===================================================================
> RCS file: /cvsroot/pgsql-server/src/include/utils/datetime.h,v
> retrieving revision 1.36
> diff -c -c -r1.36 datetime.h
> *** src/include/utils/datetime.h 20 Feb 2003 05:24:55 -0000 1.36
> --- src/include/utils/datetime.h 3 Apr 2003 06:09:41 -0000
> ***************
> *** 217,223 ****
> #endif
>
> /* Global variable holding time zone information. */
> ! #if defined(__CYGWIN__) || defined(N_PLAT_NLM)
> #define TIMEZONE_GLOBAL _timezone
> #else
> #define TIMEZONE_GLOBAL timezone
> --- 217,223 ----
> #endif
>
> /* Global variable holding time zone information. */
> ! #if defined(__CYGWIN__) || defined(WIN32) || defined(N_PLAT_NLM)
> #define TIMEZONE_GLOBAL _timezone
> #else
> #define TIMEZONE_GLOBAL timezone
We should move that to the port-specific include files, like
#define timezone _timezone
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-04-16 15:26:44 | Re: Win32 defines |
Previous Message | Hannu Krosing | 2003-04-16 14:17:47 | Re: Are we losing momentum? |